Conversation
|
📝 WalkthroughWalkthroughUpdated the local development example in the SDK core README to demonstrate loopback-based OAuth client configuration, introducing baseUrl and scope constants, embedding metadata in clientId via query parameters, deriving redirectUri from baseUrl, adjusting jwksUri to base origin, removing the developmentMode flag, and replacing the handleResolver with a production-like HTTPS resolver. Included documentation notes on configuration best practices. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/sdk-core/README.md`:
- Around line 130-132: The blockquote in README.md contains an empty line inside
the quoted paragraph causing markdownlint MD028; edit the blockquote so there
are no bare blank lines—either remove the blank line or prefix it with ">" to
keep it part of the blockquote (ensure the quoted lines like "**Embed scope and
redirect in client_id**: For loopback clients, embed scope and redirect in
client_id. Otherwise the oauth complains about missing scope and redirect."
remain contiguous and properly prefixed).
| > **Embed scope and redirect in client_id**: For loopback clients, embed scope and redirect in client_id. Otherwise the | ||
| > oauth complains about missing scope and redirect. | ||
|
|
There was a problem hiding this comment.
Fix markdownlint MD028: blank line inside blockquote.
There’s an empty line without > inside the blockquote, which triggers MD028.
🛠️ Suggested fix
> **Embed scope and redirect in client_id**: For loopback clients, embed scope and redirect in client_id. Otherwise the
> oauth complains about missing scope and redirect.
-
+>
> **Authorization Server Support**: The AT Protocol OAuth spec makes loopback support **optional**. Most AT Protocol📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| > **Embed scope and redirect in client_id**: For loopback clients, embed scope and redirect in client_id. Otherwise the | |
| > oauth complains about missing scope and redirect. | |
| > **Embed scope and redirect in client_id**: For loopback clients, embed scope and redirect in client_id. Otherwise the | |
| > oauth complains about missing scope and redirect. | |
| > | |
| > **Authorization Server Support**: The AT Protocol OAuth spec makes loopback support **optional**. Most AT Protocol |
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 132-132: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
In `@packages/sdk-core/README.md` around lines 130 - 132, The blockquote in
README.md contains an empty line inside the quoted paragraph causing
markdownlint MD028; edit the blockquote so there are no bare blank lines—either
remove the blank line or prefix it with ">" to keep it part of the blockquote
(ensure the quoted lines like "**Embed scope and redirect in client_id**: For
loopback clients, embed scope and redirect in client_id. Otherwise the oauth
complains about missing scope and redirect." remain contiguous and properly
prefixed).
Add info about client_id configuration when using a loopback url
Summary by CodeRabbit