Skip to content

Comments

[WIP] Add DID validation and support existing blob refs for profile images#124

Merged
aspiers merged 3 commits intobannerfrom
copilot/sub-pr-123
Jan 29, 2026
Merged

[WIP] Add DID validation and support existing blob refs for profile images#124
aspiers merged 3 commits intobannerfrom
copilot/sub-pr-123

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

Changes based on review comments

  • Fix DID validation regex to allow digits in method name (e.g., did:key2:, did:btc1:)
  • Add test cases for DID methods with digits
  • Strengthen isJsonBlobRef type guard to validate nested ref.$link structure
  • Export BlobInput type from main index.ts
  • Add edge case tests for malformed blob references
  • Update JSDoc comment for isValidDid() to reflect digits in method names
  • Remove package-lock.json (monorepo uses pnpm)
  • Add package-lock.json to .gitignore
  • Verify build passes - ✅ All builds successful
  • Run full test suite - ✅ 870 tests passed

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026

⚠️ No Changeset found

Latest commit: f04f5f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI and others added 2 commits January 29, 2026 08:26
- Update DID validation regex to allow digits in method names per W3C spec
- Add test cases for DIDs with numeric method names (did:key2:, did:btc1:)
- Strengthen isJsonBlobRef type guard to validate nested ref.$link structure
- Export BlobInput type from main index.ts for consumer usage
- Add edge case tests for malformed blob references

Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
- Update JSDoc comment to reflect digits allowed in DID method names
- Remove package-lock.json (monorepo uses pnpm)
- Add package-lock.json to .gitignore to prevent future commits

Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
@aspiers aspiers marked this pull request as ready for review January 29, 2026 08:30
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@aspiers aspiers merged commit fd33ee5 into banner Jan 29, 2026
1 check passed
@aspiers aspiers deleted the copilot/sub-pr-123 branch January 29, 2026 08:32
Copilot AI requested a review from aspiers January 29, 2026 08:32
Copilot stopped work on behalf of aspiers due to an error January 29, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants