Skip to content

[ci] allow claude to open PRs for certain instructions.#13536

Merged
sayakpaul merged 10 commits intomainfrom
fix-claude-workflow-post
May 10, 2026
Merged

[ci] allow claude to open PRs for certain instructions.#13536
sayakpaul merged 10 commits intomainfrom
fix-claude-workflow-post

Conversation

@sayakpaul
Copy link
Copy Markdown
Member

What does this PR do?

Potentially fixes #13472 (comment)

@sayakpaul sayakpaul requested a review from yiyixuxu April 22, 2026 00:37
@github-actions github-actions Bot added CI size/M PR with diff < 200 LOC labels Apr 22, 2026
@sayakpaul sayakpaul requested a review from paulinebm April 22, 2026 00:38
@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 22, 2026
@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 22, 2026
@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 22, 2026
Copy link
Copy Markdown
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
i left a comment,

CLAUDE_COMMIT=$(git rev-parse HEAD)

git fetch --depth=1 origin "$BASE_BRANCH"
git switch -c "$NEW_BRANCH" "origin/$BASE_BRANCH"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh i think, if we alreeady at a claude PR -> it's better if we stay there until we merge no?
so basically if i said COMMIT this from a contributor's PR -> claude open a new PR -> we iterate there where claude can directly commit into its own PR -> merge

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 23, 2026
@sayakpaul sayakpaul requested a review from yiyixuxu April 23, 2026 12:02
@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/M PR with diff < 200 LOC labels Apr 23, 2026
@sayakpaul
Copy link
Copy Markdown
Member Author

@yiyixuxu a gentle ping.

Copy link
Copy Markdown
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
let's merge it as it is and then let's open a dummy PR to test fully how it works in action, and iterate as needed?

COMMIT THIS (uppercase). If committing, only touch src/diffusers/ and .ai/.
COMMIT THIS (uppercase). If editing, only touch files under src/diffusers/ or .ai/.
A separate workflow step will commit your edits and open a follow-up PR — do NOT
run git yourself, and do NOT report on commit/push/PR status in your reply.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious what is this for

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this line, Claude tends to wrap up its reply with a made-up comment (it can't know the branch name or PR URL), and we'd end up with two conflicting status comments on the PR.

Comment thread .github/workflows/claude_review.yml Outdated
@sayakpaul sayakpaul merged commit 48f39c2 into main May 10, 2026
15 of 16 checks passed
@sayakpaul sayakpaul deleted the fix-claude-workflow-post branch May 10, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI size/M PR with diff < 200 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants