Conversation
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks for working on this!
great start
| @@ -0,0 +1,34 @@ | |||
| # PR Review Rules | |||
There was a problem hiding this comment.
there are a lot of overlaps from https://github.com/huggingface/diffusers/blob/main/.ai/skills/model-integration/SKILL.md
I think maybe we have a separate subdoc for models.md that contains the gotchas, common conventions, rules, structures etc and we can link it from everywhere: for now both AGENTS.md and the model-integration skills
what do you think? cc @stevhliu here too
these contents that are already in AGENTS.md does not need to be included here again, I think claude CI would have read the AGENTS.md. anyways no?
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] |
There was a problem hiding this comment.
can we also be able to @claude on the pr review comment? (not just issue comments) this gives it more context for stuff like we want it to add a rule based on this pattern eetc
| with: | ||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| claude_args: | | ||
| --append-system-prompt "Review this PR against the rules in .ai/review-rules.md. Focus on correctness, not style (ruff handles style). Only review changes under src/diffusers/." |
There was a problem hiding this comment.
can we add something like
only commit changes when explicitly asked using words/phrase blah blah - then maybe we can come up with a safe word for it lol
2 participants
What does this PR do?
Use Claude for PR reviews. Some choices / comments:
anthropics/claude-code-action) that auto-reviews PRs touchingsrc/diffusers/**and responds to@claudementions from folks with write access to the repo..ai/review-rules.mdfile distilled from the existingAGENTS.md, model-integration skill, and parity-testing pitfalls. It currently covers: covering code style, dependencies, models, pipelines, and copied code.@claudeadd toreview-rules.mdto never useeinops) — Claude commits the rule update to the PR branch, so rules accumulate over time with zero friction. This is inspired by https://x.com/bcherny/status/2007179842928947333.@claude.src/diffusers/**only.How to use?
src/diffusers/**.@claudeon any PR to ask Claude about the code, the diff, or the review rules.@claude add to .ai/review-rules.md to never use numpy operations in forward methods, always use torch equivalents. Claude will update the rules file and commit it to the PR branch.