perf: use deque for async map task/index queues#8033
Closed
giulio-leone wants to merge 1 commit intohuggingface:mainfrom
Closed
perf: use deque for async map task/index queues#8033giulio-leone wants to merge 1 commit intohuggingface:mainfrom
giulio-leone wants to merge 1 commit intohuggingface:mainfrom
Conversation
arrow_dataset.py and iterable_dataset.py drain indices and tasks lists front-to-back via .pop(0) during parallel async map operations. With MAX_NUM_RUNNING_ASYNC_MAP_FUNCTIONS_IN_PARALLEL items in flight, each .pop(0) is O(n) making the drain loop O(n²). Switch both queues to collections.deque with .popleft() for O(1) front removal.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Author
|
Friendly ping — CI is green and this is ready for review. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
arrow_dataset.pyanditerable_dataset.pydrainindicesandtaskslists front-to-back via.pop(0)during parallel async map operations. WithMAX_NUM_RUNNING_ASYNC_MAP_FUNCTIONS_IN_PARALLELitems in flight, each.pop(0)is O(n) making the drain loop O(n²).Solution
Switch both
indicesandtaskstocollections.dequewith.popleft()for O(1) front removal.Changes
src/datasets/arrow_dataset.py: Importdeque, typetasksandindicesas deque, use.popleft()src/datasets/iterable_dataset.py: Importdeque, typetasks,indices, and_owned_loops_and_tasksentry as deque, use.popleft()Testing
ast.parse()on both files