Fix index out of bound error with original_shard_lengths.#7987
Closed
jonathanasdf wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix index out of bound error with original_shard_lengths.#7987jonathanasdf wants to merge 1 commit intohuggingface:mainfrom
jonathanasdf wants to merge 1 commit intohuggingface:mainfrom
Conversation
I have gotten the following error
```
original_shard_lengths[original_shard_id] += 1
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
IndexError: list index out of range
```
Not sure what causes it, but this fixes the error. This may not be the proper fix for the root cause though.
Member
|
this was fixed in #8023, sorry I didn't see your PR and took the liberty of fixing this bug as part of this improvement for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have gotten the following error
Not sure what causes it, but this fixes the error. This may not be the proper fix for the root cause though.