Add support for specifying Author and Committer (issue #2199)#2200
Add support for specifying Author and Committer (issue #2199)#2200pvillard31 wants to merge 2 commits intohub4j:mainfrom
Conversation
e16057b to
088fb17
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
============================================
+ Coverage 85.03% 85.12% +0.08%
- Complexity 2499 2523 +24
============================================
Files 237 239 +2
Lines 7366 7449 +83
Branches 388 391 +3
============================================
+ Hits 6264 6341 +77
- Misses 871 877 +6
Partials 231 231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cacf7bb to
b2b9098
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
============================================
+ Coverage 85.14% 85.31% +0.16%
- Complexity 2525 2555 +30
============================================
Files 239 241 +2
Lines 7461 7544 +83
Branches 393 396 +3
============================================
+ Hits 6353 6436 +83
Misses 872 872
Partials 236 236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b2b9098 to
46dc3b4
Compare
|
Hey @bitwiseman - do you think there is a chance to see a rc6 soon with this change? Asking to see if I can afford to wait for it, or if I should work around it with direct API calls in the meantime. Having this feature would be extremely useful for my usage. |
| .author("John Doe", "john@example.com") | ||
| .author("John Doe", "john@example.com", new Date(1234567890000L)) | ||
| .committer("Service Account", "service@example.com") | ||
| .committer("Service Account", "service@example.com", new Date(1234567890000L)) |
There was a problem hiding this comment.
This isn't actually testing both signatures of each method.
I think you need a test that covers the with date methods and another that covers the non-date methods.
| .author("John Doe", "john@example.com") | ||
| .author("John Doe", "john@example.com", new Date(1234567890000L)) | ||
| .committer("Service Account", "service@example.com") | ||
| .committer("Service Account", "service@example.com", new Date(1234567890000L)) |
5a8732d to
f63133e
Compare
Description
This solves #2199. See issue for more details.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: