Add note about cache busting #3373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyroman
reviewed
Dec 29, 2025
Contributor
jeremyroman
left a comment
jeremyroman
left a comment
There was a problem hiding this comment.
This note seems, to me, too vague to be helpful. If something like this is useful, I think it'd need to explain a bit more why and what can be done about it (e.g., excluding particular query parameters for cache-busting purposes, Cache-Control: no-cache from the client; I haven't thought about this in detail lately).
| No-Vary-Search: params, except=("productId") | ||
| ~~~~ | ||
|
|
||
| Note that common approaches for ensuring caches return non-cached responses by changing query parameters are often ineffective when combined with the No-Vary-Search header field. |
Contributor
There was a problem hiding this comment.
formatting: `No-Vary-Search`
Contributor
There was a problem hiding this comment.
Wait. They aren't ineffective, they don't work at all. Or am I missing something?
reschke
requested changes
Dec 30, 2025
| No-Vary-Search: params, except=("productId") | ||
| ~~~~ | ||
|
|
||
| Note that common approaches for ensuring caches return non-cached responses by changing query parameters are often ineffective when combined with the No-Vary-Search header field. |
Contributor
There was a problem hiding this comment.
Wait. They aren't ineffective, they don't work at all. Or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3276.