Skip to content

Julian's ARTART Review #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martinthomson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Julian's ARTART Review #3349

martinthomson wants to merge 2 commits into from

Conversation

@martinthomson
Copy link
Contributor

@martinthomson martinthomson commented Dec 8, 2025

Two changes:

  • mention that buffering needs to be limited in time, not bytes; and
  • add hyperlinks to the two registries that we're adding to.

@martinthomson
Limit in time is mandatory
04eacb8 
Limit in bytes is discretionary, though likely the one that intermediaries will want.  Timers are
hard work.
@martinthomson
Link the registries
be37740
kazuho
kazuho reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I really like how the text is changed.

MikeBishop
MikeBishop approved these changes Dec 11, 2025
View reviewed changes
draft-ietf-httpbis-incremental.md
packets.

Enabling incremental delivery might set limits on the number
bytes that are buffered before forwarding.
Copy link
Contributor

@MikeBishop MikeBishop Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bytes that are buffered before forwarding.
of bytes that are buffered before forwarding.

Error in the existing text, but as long as you're touching the line....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazuho kazuho kazuho approved these changes

@reschke reschke reschke approved these changes

@MikeBishop MikeBishop MikeBishop approved these changes

@tfpauly tfpauly Awaiting requested review from tfpauly tfpauly is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@martinthomson @kazuho @reschke @MikeBishop