Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ aiohttp
# quantization
bitsandbytes>=0.44.0
buildkite-test-collector==0.1.8
pyasn1>=0.6.2 # not directly required, pinned by Snyk to avoid a vulnerability

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While pinning pyasn1 here is correct for the test environment, the fix appears to be incomplete. The awscli package, a likely source of the transitive dependency on pyasn1, is also listed in requirements-rocm.txt. Since the ROCm environment does not use this requirements file, it may remain vulnerable.

To ensure all environments are patched, this pin should also be added to requirements-common.txt (which is included by requirements-rocm.txt).

Loading