[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 7.1.0 #320
Conversation
…lities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to address a medium-severity vulnerability by upgrading the @storybook/builder-webpack5 dependency to version 7.1.0 in code/frameworks/preact-webpack5/package.json. While the dependency version has been updated in package.json, it's crucial to ensure the yarn.lock file is also updated to reflect this change and fully apply the security fix. Additionally, the change from workspace:* to a fixed version for an internal package warrants careful consideration to maintain monorepo consistency.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-webpack5": "workspace:*", | ||
| "@storybook/builder-webpack5": "7.1.0", |
There was a problem hiding this comment.
The PR description explicitly states that yarn.lock failed to update. It is critical to manually update the yarn.lock file to ensure that the 7.1.0 version of @storybook/builder-webpack5 is properly locked. Without this, the security fix might not be consistently applied across environments, and dependency resolution could lead to unexpected issues.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-webpack5": "workspace:*", | ||
| "@storybook/builder-webpack5": "7.1.0", |
There was a problem hiding this comment.
The dependency @storybook/builder-webpack5 has been changed from workspace:* to a fixed version 7.1.0. In a Yarn workspace, workspace:* typically signifies that the package should use the local version available within the monorepo. However, the local version of @storybook/builder-webpack5 (as defined in code/builders/builder-webpack5/package.json) is 8.3.0-beta.3. This change means preact-webpack5 will now fetch 7.1.0 from the npm registry, effectively downgrading from the local 8.3.0-beta.3 version and breaking the workspace:* convention. Please confirm if this is the intended behavior, as it could introduce version inconsistencies within the monorepo or unintended external dependencies. If the goal is to use the local, updated version of builder-webpack5, the dependency should ideally remain workspace:*.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/preact-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.