[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 7.1.0

[q1blue]

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• code/frameworks/ember/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Improper Handling of Unicode Encoding SNYK-JS-TAR-15038581	713

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

[gemini-code-assist]

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading a key dependency. The primary goal is to remediate a known vulnerability, ensuring the application remains robust against potential exploits. The change involves a direct version bump for a Storybook builder package, which is crucial for maintaining a secure development environment.

Highlights

• Security Vulnerability Fix: This PR addresses a medium-severity vulnerability (SNYK-JS-TAR-15038581) related to "Improper Handling of Unicode Encoding" in the tar package, identified by Snyk.
• Dependency Upgrade: The @storybook/builder-webpack5 dependency in code/frameworks/ember/package.json has been upgraded from workspace:* to 7.1.0.
• Yarn Zero-Install Note: Users employing Yarn's zero-install feature should be aware that .yarn/cache/ will need to be updated manually by running yarn after merging.
• Manual yarn.lock Update Required: The automated process failed to update the yarn.lock file, requiring a manual update before merging this PR.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, attempts to fix a security vulnerability by changing a dependency version. However, the proposed change from workspace:* to a pinned version 7.1.0 for @storybook/builder-webpack5 is incorrect for this monorepo setup. It breaks the workspace integrity by introducing a significant version downgrade and will likely lead to build or runtime issues. I have left a critical comment with a suggestion to revert this change and a recommendation for the correct approach to fix the vulnerability. This PR should not be merged in its current state.

[gemini-code-assist]

This change replaces the monorepo workspace dependency (workspace:*) with a hard-coded version. This is incorrect for this project's monorepo structure and effectively downgrades @storybook/builder-webpack5 from the workspace version (8.3.0-beta.3) to 7.1.0.

This will cause @storybook/ember to use an outdated version from the npm registry, while other packages in the monorepo use the newer version from the workspace. This inconsistency is likely to cause build failures or runtime errors. The fact that Snyk failed to update yarn.lock, as mentioned in the PR description, is another indicator that this change is problematic.

While the intent is to fix a security vulnerability, this automated change is not suitable for a monorepo. The correct approach is to address the vulnerability within the @storybook/builder-webpack5 package itself. I suggest reverting this change.

    "@storybook/builder-webpack5": "workspace:*"