Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 21, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/angular/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading the @storybook/builder-webpack5 dependency. The upgrade resolves a known medium-severity vulnerability, ensuring the project utilizes a more secure version of the package.

Highlights

  • Dependency Upgrade: Upgraded the @storybook/builder-webpack5 dependency from workspace:* (effectively 0.0.0-use.local) to 7.1.0.
  • Security Fix: This upgrade addresses a medium-severity vulnerability (SNYK-JS-TAR-15038581) related to 'Improper Handling of Unicode Encoding' in the tar package.
  • Yarn Zero-Installs Note: A specific note for users of Yarn's zero-installs feature highlights that the .yarn/cache directory will need manual updating by running yarn as the yarn.lock file was not updated by the automated process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix a security vulnerability by upgrading @storybook/builder-webpack5. However, the proposed change of pinning the version to 7.1.0 in code/frameworks/angular/package.json is incorrect for this monorepo setup. It replaces the workspace:* protocol, which is crucial for linking local packages, with a hardcoded version that is also a significant downgrade from the version 8.3.0-beta.3 currently in the workspace. This will likely break the build. The change should be reverted, and the vulnerability should be addressed by updating the yarn.lock file directly.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change is incorrect and will likely break the build in this monorepo.

  1. Breaks Workspace Linking: Changing "workspace:*" to a specific version number prevents yarn from using the local @storybook/builder-webpack5 package from this workspace. Instead, it will download version 7.1.0 from the npm registry.
  2. Version Downgrade: The version in the workspace for @storybook/builder-webpack5 is 8.3.0-beta.3 (as seen in code/builders/builder-webpack5/package.json). Pinning to 7.1.0 is a major downgrade and will cause version conflicts with other storybook packages in the monorepo that expect a version compatible with 8.3.0-beta.3.

The correct way to fix the underlying security vulnerability is to update the transitive dependency in yarn.lock, not to change the version of a workspace package here. As the PR description notes, yarn.lock failed to update, which is where the fix should be applied. This line should be reverted to its original state.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/builder-webpack5": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants