Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"dependencies": {
"@fluentui/react": "8.58.0",
"@yarnpkg/parsers": "3.0.0-rc.48.1",
"canvas": "^2.11.2",
"canvas": "^3.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version upgrade for canvas (from v2 to v3), which introduces breaking changes as noted by Snyk. While this upgrade is necessary to fix the tar vulnerability (SNYK-JS-TAR-15032660), it requires thorough regression testing of all features that rely on canvas. The project's usage of jest-canvas-mock and other canvas-related tooling should be checked for compatibility with canvas v3.

"core-js": "^3.6.5",
"d3-array": "^3.2.4",
"d3-color": "^3.1.0",
Expand All @@ -59,7 +59,7 @@
"jmespath": "^0.15.0",
"json5": "^2.1.0",
"localized-strings": "^0.2.4",
"lodash": "^4.17.11",
"lodash": "^4.17.23",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The lodash package is being updated to version 4.17.23. This version is not an official release from the lodash maintainers and is not available on the public npm registry. The yarn.lock file points to a direct .tgz URL from registry.yarnpkg.com, which might be a cached version of a since-unpublished package. This is a significant security risk, as it could be a malicious package (e.g., dependency confusion). It is strongly recommended to reject this change and stick to the latest official version, 4.17.21, until an official patch for SNYK-JS-LODASH-15053838 is released by the lodash team.

Suggested change
"lodash": "^4.17.23",
"lodash": "^4.17.21",

"memoize-one": "^5.1.1",
"minimist": "^1.2.6",
"moment": "^2.29.4",
Expand Down
Loading
Loading