-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Fix for 2 vulnerabilities #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -43,7 +43,7 @@ | |||||
| "dependencies": { | ||||||
| "@fluentui/react": "8.58.0", | ||||||
| "@yarnpkg/parsers": "3.0.0-rc.48.1", | ||||||
| "canvas": "^2.11.2", | ||||||
| "canvas": "^3.0.0", | ||||||
| "core-js": "^3.6.5", | ||||||
| "d3-array": "^3.2.4", | ||||||
| "d3-color": "^3.1.0", | ||||||
|
|
@@ -59,7 +59,7 @@ | |||||
| "jmespath": "^0.15.0", | ||||||
| "json5": "^2.1.0", | ||||||
| "localized-strings": "^0.2.4", | ||||||
| "lodash": "^4.17.11", | ||||||
| "lodash": "^4.17.23", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
| "memoize-one": "^5.1.1", | ||||||
| "minimist": "^1.2.6", | ||||||
| "moment": "^2.29.4", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade for
canvas(from v2 to v3), which introduces breaking changes as noted by Snyk. While this upgrade is necessary to fix thetarvulnerability (SNYK-JS-TAR-15032660), it requires thorough regression testing of all features that rely oncanvas. The project's usage ofjest-canvas-mockand other canvas-related tooling should be checked for compatibility withcanvasv3.