Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion microsite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@docusaurus/core": "0.0.0-5591",
"@docusaurus/plugin-client-redirects": "0.0.0-5591",
"@docusaurus/preset-classic": "0.0.0-5591",
"@swc/core": "^1.3.46",
"@swc/core": "^1.13.20",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🐛 Significant Version Jump Without Gradual Migration: The upgrade jumps from 1.3.46 to 1.13.20/1.14.0, skipping numerous intermediate versions that contained breaking changes. Multiple AST breaking changes occurred between these versions, creating risk of build failures, transpilation errors, or runtime issues in the microsite.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: 🔒 Missing Compatibility Verification: No evidence of compatibility testing with the current Docusaurus version and SWC loader configuration. The microsite uses swc-loader version 0.2.3 which has peer dependency @swc/core: ^1.2.147. SWC 1.14.0 may introduce compatibility issues with this older loader version, and Docusaurus webpack configuration may not be compatible with SWC 1.14.x.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: ✨ Build Pipeline Impact Unknown: The microsite deployment workflow may be affected by SWC changes. The deploy_microsite.yml workflow builds the microsite with yarn build which uses SWC for transpilation, and this needs to be tested to ensure no breakage.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: ✨ Version Specification Inconsistency: Version specified as ^1.13.20 but resolves to 1.14.0. Consider using exact version pinning for critical build tools like SWC to ensure reproducible builds.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@swc/core": "^1.13.20",
"@swc/core": "1.14.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: ✨ Missing Changelog or Migration Notes: No documentation of the upgrade reasoning or migration steps. Add context about why this upgrade is needed and what testing was performed to help future maintainers understand the change.

"clsx": "^1.1.1",
"docusaurus-plugin-sass": "^0.2.3",
"luxon": "^3.0.0",
Expand Down
116 changes: 67 additions & 49 deletions microsite/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2604,92 +2604,94 @@ __metadata:
languageName: node
linkType: hard

"@swc/core-darwin-arm64@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-darwin-arm64@npm:1.3.68"
"@swc/core-darwin-arm64@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-darwin-arm64@npm:1.14.0"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard

"@swc/core-darwin-x64@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-darwin-x64@npm:1.3.68"
"@swc/core-darwin-x64@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-darwin-x64@npm:1.14.0"
conditions: os=darwin & cpu=x64
languageName: node
linkType: hard

"@swc/core-linux-arm-gnueabihf@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-arm-gnueabihf@npm:1.3.68"
"@swc/core-linux-arm-gnueabihf@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-arm-gnueabihf@npm:1.14.0"
conditions: os=linux & cpu=arm
languageName: node
linkType: hard

"@swc/core-linux-arm64-gnu@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-arm64-gnu@npm:1.3.68"
"@swc/core-linux-arm64-gnu@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-arm64-gnu@npm:1.14.0"
conditions: os=linux & cpu=arm64 & libc=glibc
languageName: node
linkType: hard

"@swc/core-linux-arm64-musl@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-arm64-musl@npm:1.3.68"
"@swc/core-linux-arm64-musl@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-arm64-musl@npm:1.14.0"
conditions: os=linux & cpu=arm64 & libc=musl
languageName: node
linkType: hard

"@swc/core-linux-x64-gnu@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-x64-gnu@npm:1.3.68"
"@swc/core-linux-x64-gnu@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-x64-gnu@npm:1.14.0"
conditions: os=linux & cpu=x64 & libc=glibc
languageName: node
linkType: hard

"@swc/core-linux-x64-musl@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-linux-x64-musl@npm:1.3.68"
"@swc/core-linux-x64-musl@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-linux-x64-musl@npm:1.14.0"
conditions: os=linux & cpu=x64 & libc=musl
languageName: node
linkType: hard

"@swc/core-win32-arm64-msvc@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-win32-arm64-msvc@npm:1.3.68"
"@swc/core-win32-arm64-msvc@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-win32-arm64-msvc@npm:1.14.0"
conditions: os=win32 & cpu=arm64
languageName: node
linkType: hard

"@swc/core-win32-ia32-msvc@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-win32-ia32-msvc@npm:1.3.68"
"@swc/core-win32-ia32-msvc@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-win32-ia32-msvc@npm:1.14.0"
conditions: os=win32 & cpu=ia32
languageName: node
linkType: hard

"@swc/core-win32-x64-msvc@npm:1.3.68":
version: 1.3.68
resolution: "@swc/core-win32-x64-msvc@npm:1.3.68"
"@swc/core-win32-x64-msvc@npm:1.14.0":
version: 1.14.0
resolution: "@swc/core-win32-x64-msvc@npm:1.14.0"
conditions: os=win32 & cpu=x64
languageName: node
linkType: hard

"@swc/core@npm:^1.3.46":
version: 1.3.68
resolution: "@swc/core@npm:1.3.68"
dependencies:
"@swc/core-darwin-arm64": 1.3.68
"@swc/core-darwin-x64": 1.3.68
"@swc/core-linux-arm-gnueabihf": 1.3.68
"@swc/core-linux-arm64-gnu": 1.3.68
"@swc/core-linux-arm64-musl": 1.3.68
"@swc/core-linux-x64-gnu": 1.3.68
"@swc/core-linux-x64-musl": 1.3.68
"@swc/core-win32-arm64-msvc": 1.3.68
"@swc/core-win32-ia32-msvc": 1.3.68
"@swc/core-win32-x64-msvc": 1.3.68
peerDependencies:
"@swc/helpers": ^0.5.0
"@swc/core@npm:^1.13.20":
version: 1.14.0
resolution: "@swc/core@npm:1.14.0"
dependencies:
"@swc/core-darwin-arm64": 1.14.0
"@swc/core-darwin-x64": 1.14.0
"@swc/core-linux-arm-gnueabihf": 1.14.0
"@swc/core-linux-arm64-gnu": 1.14.0
"@swc/core-linux-arm64-musl": 1.14.0
"@swc/core-linux-x64-gnu": 1.14.0
"@swc/core-linux-x64-musl": 1.14.0
"@swc/core-win32-arm64-msvc": 1.14.0
"@swc/core-win32-ia32-msvc": 1.14.0
"@swc/core-win32-x64-msvc": 1.14.0
"@swc/counter": ^0.1.3
"@swc/types": ^0.1.25
peerDependencies:
"@swc/helpers": ">=0.5.17"
dependenciesMeta:
"@swc/core-darwin-arm64":
optional: true
Expand All @@ -2714,7 +2716,23 @@ __metadata:
peerDependenciesMeta:
"@swc/helpers":
optional: true
checksum: f56ad1d4cb91f7cc1cb5d4b9894bbb528da0b2eabc98984581f5b3f3187cf2c0d512003880f6ff7a3f6d215b7a3dcbf5a9c45e8a428ac2d711941027c0151d89
checksum: 107f3e9f3655b5011db2a5d1816331a241a99488088db9ae3b715bde11219776935e77ab0a47ad4d44c5f799ebafceb34d1e4c547c8af56dc12b9e6feec2d397
languageName: node
linkType: hard

"@swc/counter@npm:^0.1.3":
version: 0.1.3
resolution: "@swc/counter@npm:0.1.3"
checksum: df8f9cfba9904d3d60f511664c70d23bb323b3a0803ec9890f60133954173047ba9bdeabce28cd70ba89ccd3fd6c71c7b0bd58be85f611e1ffbe5d5c18616598
languageName: node
linkType: hard

"@swc/types@npm:^0.1.25":
version: 0.1.25
resolution: "@swc/types@npm:0.1.25"
dependencies:
"@swc/counter": ^0.1.3
checksum: 8e8ec73913aa42ee574c2a5a95fb6a95f19c5f011e66ed3faf773aa26f731e3f9a8b8e4d9e1887124166504253ee9e16d87f292e0ea1411d6170a4d1b327ba25
languageName: node
linkType: hard

Expand Down Expand Up @@ -3757,7 +3775,7 @@ __metadata:
"@docusaurus/plugin-client-redirects": 0.0.0-5591
"@docusaurus/preset-classic": 0.0.0-5591
"@spotify/prettier-config": ^14.0.0
"@swc/core": ^1.3.46
"@swc/core": ^1.13.20
"@tsconfig/docusaurus": ^1.0.6
"@types/luxon": ^3.0.0
"@types/webpack-env": ^1.18.0
Expand Down Expand Up @@ -11182,7 +11200,7 @@ __metadata:

"typescript@patch:typescript@^4.9.4#~builtin<compat/typescript>":
version: 4.9.5
resolution: "typescript@patch:typescript@npm%3A4.9.5#~builtin<compat/typescript>::version=4.9.5&hash=a1c5e5"
resolution: "typescript@patch:typescript@npm%3A4.9.5#~builtin<compat/typescript>::version=4.9.5&hash=701156"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
Expand Down
Loading