Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Oct 23, 2025

snyk-top-banner

Snyk has created this PR to upgrade sass from 1.60.0 to 1.93.2.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 86 versions ahead of your current version.

  • The recommended version was released a month ago.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:


EntelligenceAI PR Summary

Upgraded Sass preprocessor in the Backstage microsite from version ~1.57.1/1.60.0 to 1.93.2, introducing new file watching capabilities and modernized dependencies. This update includes significant changes to the Sass dependency tree.

@codesandbox
Copy link

codesandbox bot commented Oct 23, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link

snyk-io bot commented Oct 23, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link

📝 Walkthrough

This PR upgrades the Sass preprocessor in the Backstage microsite from version ~1.57.1/1.60.0 to 1.93.2. The change brings significant updates to the Sass dependency tree, introducing new file watching capabilities through @parcel/watcher and modernizing several dependencies.

The upgrade includes a major version change for immutable.js (v4.2.2 to v5.1.4) which has breaking changes in its API. Additionally, the introduction of @parcel/watcher brings native C++ binaries that require proper compilation environments. Despite these potential concerns, analysis shows the microsite doesn't directly use immutable.js, and the codebase uses modern Sass syntax that's compatible with the new version.

📊 Changes

File Change
microsite/package.json Updated sass version from ^1.57.1 to ^1.93.2
microsite/yarn.lock Updated dependency resolution with new packages and versions

⚠️ Potential Issues

  • Immutable.js Breaking Changes: The upgrade introduces a major version change (v4.2.2 to v5.1.4) with significant API changes
  • Native Dependencies: New @parcel/watcher dependency requires proper C++ compilation environment
  • Sass Breaking Changes: Version jump includes several breaking changes to Sass functionality
  • Chokidar Upgrade: File watcher upgraded from 3.5.3 to 4.0.3 with potential behavior changes

✅ Compatibility

  • Modern Sass syntax (@use instead of @import) already in use and compatible
  • Optional dependency structure ensures graceful degradation
  • Improved platform support for ARM64, Linux distributions, and Windows

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    title SASS Dependency Update Workflow

    participant App as "Microsite Application"
    participant Sass as "SASS Compiler"
    participant Watcher as "@parcel/watcher"
    participant FS as "File System"
    participant Chokidar as "Chokidar v4"
    participant Immutable as "Immutable v5"

    Note over App,Immutable: The PR updates SASS from v1.57.1 to v1.93.2 with new dependencies

    App->>Sass: Initialize SASS compiler
    activate Sass
    
    Sass->>Watcher: Initialize file watching (new dependency)
    activate Watcher
    Note over Watcher: New dependency added in v1.93.2
    
    Sass->>Chokidar: Setup file watching
    activate Chokidar
    Note over Chokidar: Upgraded from v3.x to v4.0.3
    
    Sass->>Immutable: Create immutable data structures
    activate Immutable
    Note over Immutable: Upgraded from v4.x to v5.1.4
    
    alt Using @parcel/watcher (preferred)
        Sass->>Watcher: Watch for SCSS file changes
        Watcher-->>FS: Monitor file system events
        FS-->>Watcher: File change detected
        Watcher-->>Sass: Notify of file changes
    else Fallback to Chokidar
        Note over Sass,Chokidar: @parcel/watcher is optional
        Sass->>Chokidar: Watch for SCSS file changes
        Chokidar-->>FS: Monitor file system events
        FS-->>Chokidar: File change detected
        Chokidar-->>Sass: Notify of file changes
    end
    
    FS->>Sass: Read SCSS source files
    Sass->>Immutable: Store parsed AST in immutable structures
    Immutable-->>Sass: Return immutable data
    
    Sass->>Sass: Compile SCSS to CSS
    Sass-->>App: Return compiled CSS
    
    deactivate Immutable
    deactivate Chokidar
    deactivate Watcher
    deactivate Sass
Loading

🔒 Security Analysis

  • Vulnerabilities: 0
  • Bugs: 0
  • Code Smells: 0
  • Security Hotspots: 0

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

"react": "^17.0.2",
"react-dom": "^17.0.2",
"sass": "^1.57.1",
"sass": "^1.93.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: Immutable.js major version breaking change from v4.2.2 to v5.1.4 introduced by Sass upgrade, which includes API changes like removed default export, changed TypeScript definitions, and Map behavior changes

"react": "^17.0.2",
"react-dom": "^17.0.2",
"sass": "^1.57.1",
"sass": "^1.93.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: Introduction of @parcel/watcher with native C++ binaries requires Node-gyp compilation environment, platform-specific build tools, and architecture-specific native modules

"react": "^17.0.2",
"react-dom": "^17.0.2",
"sass": "^1.57.1",
"sass": "^1.93.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: Sass breaking changes between versions 1.57.1 and 1.93.2, including @function definitions with name type(), private variables in @with, legacy JS API deprecation, and color function deprecations

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Oct 30, 2025
@github-actions github-actions bot closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants