Skip to content

[Snyk] Fix for 6 vulnerabilities #10446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/explore-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "0.1.1",
"@backstage/plugin-explore-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "0.3.6",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +25 to +29
Copy link

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency updates have several critical issues:

  1. Major Downgrades: @backstage/config is downgraded from workspace version 1.0.8 to 0.1.1 (line 26), and @backstage/plugin-search-common is downgraded from 1.2.5 to 0.3.1 (line 29). These are massive downgrades that will almost certainly break the application.
  2. Incorrect Dependency Strategy: The change from workspace:^ to pinned versions is problematic in a monorepo. It can lead to version conflicts and bloat. The recommended approach is to either update the workspace packages themselves or use resolutions in the root package.json to fix transitive vulnerabilities without breaking workspace linking.

Given these issues, these changes should be reverted. The lodash update on line 34 is correct, but these changes to @backstage packages are not.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/config": "0.1.1",
"@backstage/plugin-explore-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "0.3.6",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-explore-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",

"@backstage/types": "workspace:^",
"@types/express": "*",
"express": "^4.18.1",
"express-promise-router": "^4.1.0",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"node-fetch": "^2.6.7",
"winston": "^3.2.1",
"yn": "^4.0.0"
Expand Down
Loading