Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/scaffolder-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
"url": "https://github.com/backstage/backstage/issues"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"
Comment on lines +56 to +58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/catalog-model and @backstage/types to specific versions is incorrect in this Yarn workspace setup. It breaks the monorepo's internal dependency linking, which relies on workspace:^. Furthermore, the pinned versions (0.1.1) are significant downgrades from the versions available in the workspace (@backstage/catalog-model is at 1.4.1, @backstage/types is at 1.1.0), which will almost certainly cause build failures and runtime errors. These dependencies should be reverted to use workspace:^.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading