Skip to content

[Snyk] Fix for 6 vulnerabilities #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

[Snyk] Fix for 6 vulnerabilities #10430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/entity-feedback-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-common": "0.25.0",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
Comment on lines +25 to +30
Copy link

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces severe downgrades for several packages and removes the workspace: protocol, which can cause significant issues.

  • @backstage/catalog-client is downgraded from a workspace version compatible with 1.4.3 to 0.2.0.
  • @backstage/catalog-model is downgraded from a workspace version compatible with 1.4.1 to 0.1.1.

These major version downgrades will almost certainly lead to build failures or runtime errors due to breaking API changes.

While other packages are upgraded, pinning versions like this instead of using workspace:^ can lead to version conflicts and maintenance challenges in a monorepo. It seems the automated tool has made an error.

It's recommended to reject these changes and investigate the proper way to resolve the security vulnerabilities, which might involve updating the versions of these packages across the entire workspace rather than pinning them in this one file. Also, as noted in the PR description, the yarn.lock file needs to be updated after any dependency change.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^"

"@backstage/plugin-entity-feedback-common": "workspace:^",
"@types/express": "*",
"express": "^4.18.1",
Expand Down
Loading