Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"dependencies": {
"@backstage/cli-common": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces a workspace dependency (workspace:^) with a pinned external version. This is incorrect in a monorepo as it breaks the internal package linking and can lead to inconsistent dependency resolution. Packages within the monorepo should reference each other using the workspace: protocol to ensure they use the code from the same repository.

Furthermore, this change appears to be a downgrade. The @backstage/types package within this monorepo is at version 1.1.0, and this change pins it to 0.1.1. This will likely cause build failures and should be reverted.

The security vulnerability should be addressed by updating the yarn.lock file, not by changing how workspace packages are referenced.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

"@manypkg/get-packages": "^1.1.3",
"@yarnpkg/parsers": "^3.0.0-rc.4",
"fs-extra": "10.1.0",
Expand Down
Loading