Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/vault/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces a yarn workspace dependency (workspace:^) with a pinned version from the registry. This is likely a misinterpretation by Snyk of the monorepo setup. The local version of @backstage/theme in this repository is 0.4.1 (as seen in packages/theme/package.json), which is much newer than the suggested 0.1.1. This change is effectively a downgrade and will likely cause dependency conflicts or unexpected behavior by pulling an old version from the registry instead of using the local package from the workspace.

It is recommended to revert this change and investigate the vulnerability within the context of the monorepo. If @backstage/theme or its dependencies need an update, it should be done while preserving the workspace:^ protocol to maintain monorepo integrity.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading