forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #10363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
q1blue
wants to merge
1
commit into
master
Choose a base branch
from
snyk-fix-4106f2c9771f5c21b40bc3fb9dba93f4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly replaces a yarn workspace dependency (
workspace:^) with a pinned version from the registry. This is likely a misinterpretation by Snyk of the monorepo setup. The local version of@backstage/themein this repository is0.4.1(as seen inpackages/theme/package.json), which is much newer than the suggested0.1.1. This change is effectively a downgrade and will likely cause dependency conflicts or unexpected behavior by pulling an old version from the registry instead of using the local package from the workspace.It is recommended to revert this change and investigate the vulnerability within the context of the monorepo. If
@backstage/themeor its dependencies need an update, it should be done while preserving theworkspace:^protocol to maintain monorepo integrity.