Skip to content

[Snyk] Fix for 1 vulnerabilities #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

[Snyk] Fix for 1 vulnerabilities #10362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/codescene/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +25 to +27
Copy link

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes are incorrect and should be reverted. They replace workspace-local dependencies (workspace:^) with old, hard-pinned versions from the public registry.

This will likely break the build and the application because:

  1. It breaks the Yarn workspace linking mechanism, which is essential in this monorepo.
  2. It introduces major version downgrades for these core packages. For example, @backstage/config is being downgraded from a much newer version in the workspace to 0.1.1.

The vulnerability in tar should be addressed by using resolutions in the root package.json to force a non-vulnerable version, or by upgrading the direct dependency that brings in tar. These changes do not correctly fix the issue and introduce breaking changes.

    "@backstage/config": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading