Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-aws/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,17 @@
"@aws-sdk/credential-providers": "^3.350.0",
"@aws-sdk/middleware-endpoint": "^3.347.0",
"@aws-sdk/types": "^3.347.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-kubernetes-common": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/plugin-kubernetes-common": "0.1.0",
Comment on lines +54 to +64

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated changes from Snyk are incorrect for this monorepo and are likely to cause issues.

  • Breaking Workspace Links: The changes replace workspace:^ dependencies with pinned versions. This breaks the local linking within the monorepo, which is a core part of its structure.
  • Dependency Downgrades: Some of the pinned versions are significant downgrades from the versions currently in the workspace. For example:
    • @backstage/catalog-model is downgraded from 1.4.1 to 0.1.1.
    • @backstage/plugin-catalog-node is downgraded from 1.4.1-next.0 to 1.0.0.
    • @backstage/plugin-kubernetes-common is downgraded from 0.6.5 to 0.1.0.
      These downgrades could re-introduce old bugs or cause compatibility issues.

The vulnerability SNYK-JS-TAR-15038581 is in the tar package, which is a dependency of @backstage/backend-common. The correct fix is to update the tar dependency within packages/backend-common/package.json and then update the yarn.lock file.

These changes should be reverted.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/integration-aws-node": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^",
    "@backstage/plugin-kubernetes-common": "workspace:^"

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"p-limit": "^3.0.2",
Expand Down
Loading