Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/catalog-model/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Comment on lines +47 to +49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Downgrading @backstage/config and @backstage/types and removing the workspace:^ specifier is highly problematic. This change pins these dependencies to very old versions (0.1.1), while the versions in the workspace are 1.0.8 and 1.1.0 respectively.

This massive downgrade will almost certainly break the build, as @backstage/catalog-model@1.4.1 likely depends on APIs from the 1.x versions that are not present in 0.1.1. The fact that Snyk failed to update yarn.lock is a strong indicator that this change introduces dependency conflicts.

To fix the underlying tar vulnerability without breaking your project, you should use Yarn's resolutions feature in the root package.json to force a secure version of tar across the entire workspace. This avoids disruptive changes to your direct dependencies.

Example for root package.json:

"resolutions": {
  "tar": "6.1.11" // Or a newer, non-vulnerable version
}

After adding this, you will need to run yarn install to update the yarn.lock file.

I recommend rejecting these changes and using the resolutions approach instead.

    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/types": "workspace:^"

"ajv": "^8.10.0",
"json-schema": "^0.4.0",
"lodash": "^4.17.21",
Expand Down
Loading