Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/explore-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-explore-common": "workspace:^"
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-explore-common": "0.0.1"
Comment on lines +35 to +36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes introduce a critical issue. The @backstage/core-plugin-api is being downgraded to version 0.1.0, while the current version in the workspace is 1.5.3. This is a major downgrade that will likely cause build failures and runtime errors.

Furthermore, replacing workspace:^ with pinned versions breaks the monorepo's dependency management strategy. Packages within this workspace are intended to reference each other using the workspace: protocol to ensure they use the code from the same monorepo, not from a published registry. The correct way to fix vulnerabilities is to update the dependencies within the workspace and then update the yarn.lock file, not to pin to old, published versions.

Suggested change
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-explore-common": "0.0.1"
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-explore-common": "workspace:^"

},
"peerDependencies": {
"react": "^16.13.1 || ^17.0.0",
Expand Down
Loading