Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/tech-insights/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/core-plugin-api from a workspace dependency to a fixed, very old version (0.1.0). The version in your workspace is 1.5.3. This massive downgrade will likely break your application. This seems to be an error from the automated tool, which likely doesn't understand the workspace:^ protocol. This change should be reverted.

Suggested change
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",

"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
"@backstage/plugin-tech-insights-common": "0.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the change for @backstage/core-plugin-api, this incorrectly downgrades @backstage/plugin-tech-insights-common to version 0.1.0 from a workspace dependency. The version in your workspace is 0.2.11. This will likely cause breakages and should be reverted. The underlying vulnerability should be fixed by correctly updating dependencies within the yarn workspace.

Suggested change
"@backstage/plugin-tech-insights-common": "0.1.0",
"@backstage/plugin-tech-insights-common": "workspace:^",

"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading