Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dependencies": {
"@backstage/cli-common": "workspace:^",
"@backstage/create-app": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:^ to a pinned version 0.1.1 is incorrect for a monorepo. The e2e-test package should use the version of @backstage/errors from the local workspace to ensure it's testing the current code. Pinning to a published version (0.1.1) means the e2e tests will run against an old version of the package, not the one in this repository (which is at version 1.2.1). This defeats the purpose of these tests.

The Snyk PR description notes that it "Failed to update the yarn.lock", which indicates the automated tool is likely struggling with the monorepo setup.

To fix the underlying security vulnerability, you should use Yarn's resolutions feature in the root package.json to enforce a secure version of the transitive dependency across the entire monorepo. This will fix the vulnerability without breaking the workspace linking.

Suggested change
"@backstage/errors": "0.1.1",
"@backstage/errors": "workspace:^",

"chalk": "^4.0.0",
"commander": "^9.1.0",
"cross-fetch": "^3.1.5",
Expand Down
Loading