Skip to content

[Snyk] Fix for 1 vulnerabilities #10354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 1 vulnerabilities #10354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/tech-insights-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
Comment on lines +35 to +36
Copy link

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning dependency versions here and removing workspace:^ goes against the yarn workspace conventions used in this monorepo. This can lead to having multiple versions of the same package, break local development workflows, and make dependency management much harder.

The correct way to resolve the underlying vulnerability is to update the dependencies within the workspace. You should revert these changes and then run a command like yarn upgrade-interactive --latest to resolve to a non-vulnerable version of the transitive dependency (tar), and then run yarn install to update the yarn.lock file.

As the PR description also warns, yarn.lock has not been updated, which is a critical omission. Without an updated lockfile, the vulnerability is not actually fixed.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-tasks": "workspace:^"

"@backstage/config": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
"@backstage/types": "workspace:^",
Expand Down
Loading