Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/search-backend-module-explore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-explore-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +39 to +45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions are incorrect for a Yarn workspace-based monorepo. This will cause packages to be fetched from the npm registry instead of being linked locally from the workspace, which can lead to inconsistencies and breakages, especially since some of these changes are significant downgrades (e.g., @backstage/plugin-search-backend-node from 1.2.x to 0.1.2).

The vulnerability is in the tar package, which is a dependency of @backstage/backend-common. The correct way to fix this is to update the tar dependency within packages/backend-common/package.json and then run yarn install to update the yarn.lock file. This automated PR should be rejected.

A suggested fix would be to update tar in packages/backend-common/package.json to a non-vulnerable version, for example ^6.2.1.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-explore-common": "workspace:^",
    "@backstage/plugin-search-backend-node": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"node-fetch": "^2.6.7",
"winston": "^3.2.1"
},
Expand Down
Loading