Skip to content

[Snyk] Fix for 1 vulnerabilities #10351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 1 vulnerabilities #10351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-puppetdb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +50 to +56
Copy link

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated dependency updates are incorrect and should be rejected.

  1. Breaks Monorepo Dependency Linking: The change from workspace:^ to pinned versions is incorrect for a Yarn workspace-based monorepo. It severs the link to local packages, causing this module to use potentially outdated, published versions instead of the current source code from within this repository.

  2. Major Version Downgrades: This change introduces severe downgrades for critical packages, which will likely break the application:

    • @backstage/catalog-model is downgraded from its workspace version 1.4.1 to 0.1.1.
    • @backstage/plugin-catalog-node is downgraded from its workspace version 1.4.1-next.0 to 1.0.0.

  3. Incomplete Change: As noted in the PR description, yarn.lock was not updated, which means the dependency tree is unresolved and likely broken.

Instead of accepting this change, the underlying vulnerability in the tar package should be resolved by updating it across the entire monorepo, while preserving the workspace:^ protocol for internal packages.

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"luxon": "^3.0.0",
Expand Down
Loading