Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/code-climate/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces the workspace dependency workspace:^ with a pinned version 0.1.1. This is a significant downgrade, as the version of @backstage/theme within this monorepo is 0.4.1 (as seen in packages/theme/package.json). Using an older, pinned version breaks the integrity of the monorepo, can lead to version mismatches, and may cause runtime errors or unexpected behavior because other parts of the application will be using a different version of the theme.

While this change is intended to fix security vulnerabilities, the correct approach in a monorepo is to update the dependencies within the @backstage/theme package itself or other relevant packages to resolve the vulnerabilities, rather than pinning to an old version of a workspace package.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading