Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/events-backend-module-bitbucket-cloud/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/plugin-events-node": "0.2.9",
Comment on lines +38 to +39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While updating these dependencies is necessary to fix vulnerabilities, changing the version from workspace:^ to a pinned version is incorrect for this monorepo setup. The workspace:^ protocol ensures that local packages from the yarn workspace are used. Pinning to a specific version will cause yarn to fetch these packages from the registry, ignoring the local versions and potentially causing inconsistencies or breaking changes.

The correct approach is to update the versions of the @backstage/backend-plugin-api and @backstage/plugin-events-node packages within the monorepo itself, and then run yarn to update the yarn.lock file. This will preserve the workspace linking while resolving the vulnerabilities.

    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/plugin-events-node": "workspace:^"

"winston": "^3.2.1"
},
"devDependencies": {
Expand Down
Loading