-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 5 vulnerabilities #10344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,9 +33,9 @@ | |
| "clean": "backstage-cli package clean" | ||
| }, | ||
| "dependencies": { | ||
| "@backstage/backend-common": "workspace:^", | ||
| "@backstage/backend-common": "0.24.1", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/errors": "0.1.1", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The update of |
||
| "@backstage/plugin-tech-insights-common": "workspace:^", | ||
| "@backstage/plugin-tech-insights-node": "workspace:^", | ||
| "ajv": "^8.10.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing
@backstage/backend-commonfromworkspace:^to a fixed version0.24.1deviates from the typical monorepo practice of usingworkspace:^for internal dependencies. This might lead to version inconsistencies if the root workspace version is updated but this package remains pinned. Consider if this specific version pin is a temporary measure for the Snyk fix, or if the overall workspace dependency strategy needs adjustment to ensure all internal packages are aligned.