Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/tech-insights-backend-module-jsonfc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing @backstage/backend-common from workspace:^ to a fixed version 0.24.1 deviates from the typical monorepo practice of using workspace:^ for internal dependencies. This might lead to version inconsistencies if the root workspace version is updated but this package remains pinned. Consider if this specific version pin is a temporary measure for the Snyk fix, or if the overall workspace dependency strategy needs adjustment to ensure all internal packages are aligned.

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update of @backstage/errors from workspace:^ to 0.1.1 presents the same potential for version misalignment within the monorepo as noted for @backstage/backend-common. It is important to ensure this fixed version aligns with the intended long-term dependency management strategy for internal packages.

"@backstage/plugin-tech-insights-common": "workspace:^",
"@backstage/plugin-tech-insights-node": "workspace:^",
"ajv": "^8.10.0",
Expand Down
Loading