-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade next from 13.1.6 to 15.5.10 #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated security fix initiated by Snyk to upgrade the Next.js framework to a newer, more secure version. The primary goal is to mitigate a high-severity vulnerability, ensuring the application's stability and security. This update involves a significant bump in the Next.js version, which consequently triggers a cascade of updates and additions across various related dependencies, reflecting the evolution of the framework's internal architecture and tooling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
🤖 Augment PR SummarySummary: This PR upgrades Next.js to address a high-severity Snyk-reported vulnerability. Changes:
Technical Notes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "micro": "^10.0.1", | ||
| "micro-cors": "^0.1.1", | ||
| "next": "13.1.6", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "micro": "^10.0.1", | ||
| "micro-cors": "^0.1.1", | ||
| "next": "13.1.6", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades next from version 13.1.6 to 15.5.10 to fix a security vulnerability. This is a major version upgrade, which can introduce breaking changes. I've reviewed the dependency changes and found a few areas for improvement to ensure consistency and prevent potential issues. Specifically, I've recommended updating the related eslint-config-next package, aligning the Node.js engine requirement in your package.json, and fixing an inconsistency in the package-lock.json for the next dependency versioning.
| "micro": "^10.0.1", | ||
| "micro-cors": "^0.1.1", | ||
| "next": "13.1.6", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| }, | ||
| "engines": { | ||
| "node": ">=14.6.0" | ||
| "node": "^18.18.0 || ^19.8.0 || >= 20.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in next's engine requirement is not reflected in the root package.json. The root engines.node is set to ">=18.0.0", which is not fully compatible with "^18.18.0 || ^19.8.0 || >= 20.0.0". This could lead to environment-specific issues where a developer's Node.js version satisfies the project's requirement but not next's. It's recommended to update the engines.node field in the root package.json to a compatible range, for example: "^18.18.0 || >=20.0.0".
| "micro": "^10.0.1", | ||
| "micro-cors": "^0.1.1", | ||
| "next": "13.1.6", | ||
| "next": "^15.5.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json file specifies an exact version for next (15.5.10), but here in the lock file a caret range (^15.5.10) is used. This can lead to future npm install commands pulling a newer, potentially breaking, version of next. To ensure dependency stability, especially after a major version upgrade, this should be an exact version to match package.json. You can fix this by running npm install again or manually editing the line.
| "next": "^15.5.10", | |
| "next": "15.5.10", |



Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling