Skip to content

fix: Allow options to appear before URL (#1592) #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plausibleCoder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Allow options to appear before URL (#1592) #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions httpie/cli/argparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,28 @@ def __init__(self, *args, formatter_class=HTTPieHelpFormatter, **kwargs):
super().__init__(*args, formatter_class=formatter_class, **kwargs)

# noinspection PyMethodOverriding
# In parse_args method
def parse_args(
self,
env: Environment,
args=None,
namespace=None
self, env: Environment, args=None, namespace=None
) -> argparse.Namespace:
self.env = env
self.env.args = namespace = namespace or argparse.Namespace()
# Manually reorder args to handle options appearing before the URL.
# Fix for Issue #1592.
if args is None:
args = sys.argv[1:]

new_args = []
positionals = []
for arg in args:
if not arg.startswith('-'):
positionals.append(arg)
else:
new_args.append(arg)

# Put the collected positionals at the front, then the optionals.
args = positionals + new_args

self.args, no_options = super().parse_known_args(args, namespace)
if self.args.debug:
self.args.traceback = True
Expand Down
Loading