Skip to content

Mark "split large buffers" test flaky #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danicheg merged 3 commits into from
Dec 3, 2022
Merged

Mark "split large buffers" test flaky #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e1b652
Mark "split large buffers" test flaky
rossabaker Nov 30, 2022
97b7319
Override munitFlakyOK in BlazeTestSuite
danicheg Dec 1, 2022
0bd4458
Fix marking the test as flaky
danicheg Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/test/scala/org/http4s/blaze/pipeline/stages/SSLStageSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ class SSLStageSuite extends BlazeTestSuite {
} yield ()
}

test(testSuitePrefix + " should split large buffers") {
test((testSuitePrefix + " should split large buffers").flaky) {
Copy link
Copy Markdown
Member

@danicheg danicheg Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes me whaaaat

test(testSuitePrefix + " should split large buffers".flaky) {} // compiles but doesn't work properly

Copy link
Copy Markdown
Member

@danicheg danicheg Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though nothing new, silly type-weakness of string concatenation

Copy link
Copy Markdown
Member Author

@rossabaker rossabaker Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good find. I always thought it was odd that operator went on the String in the first place.

// See https://github.com/http4s/blaze/pull/771 for a deeper
// analysis of the flake and possible solutions.
val (headEng, stageEng) = mkClientServerEngines
val s = "Fo" * (stageEng.getSession.getPacketBufferSize * 0.75).toInt

Expand Down
3 changes: 3 additions & 0 deletions testkit/src/main/scala/org/http4s/blaze/testkit/BlazeTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ import scala.util.control.NonFatal

abstract class BlazeTestSuite extends FunSuite with BlazeAssertions {
implicit val executionContext: ExecutionContext = ExecutionContext.Implicits.global

// allow flaky tests on ci
override def munitFlakyOK: Boolean = sys.env.contains("CI")
}

trait BlazeAssertions { self: Assertions =>
Expand Down