Add max wait for connection borrowing in pool manager#681
Open
danicheg wants to merge 1 commit intohttp4s:series/0.23from
Open
Add max wait for connection borrowing in pool manager#681danicheg wants to merge 1 commit intohttp4s:series/0.23from
danicheg wants to merge 1 commit intohttp4s:series/0.23from
Conversation
| case None if maxConnectionsPerRequestKey(key) <= 0 => | ||
| F.delay(callback(Left(NoConnectionAllowedException(key)))) | ||
|
|
||
| case None if curTotal == maxTotal => |
There was a problem hiding this comment.
Just a minor thing that comes to mind: what if we added a guard clause here like
Suggested change
| case None if curTotal == maxTotal => | |
| case None if curTotal == maxTotal && idleQueues.keys.nonEmpty => |
so to expunge the else branch on line 267 on, and make the match branch on line 275 to become
case _ =>
to take care of that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654. Transferred from http4s/http4s#6387.