construct bodies from impl Read instead of impl BufRead#298
Draft
construct bodies from impl Read instead of impl BufRead#298
Conversation
jbr
force-pushed
the
dont-buffer-bodies
branch
from
1281620 to
7cf5f91
Compare
Member
|
Marked as draft so we physically can't merge until 3.0. |
yoshuawuyts
approved these changes
Dec 18, 2020
Member
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
One nit, but otherwise good!
Member
|
What's this waiting on? |
Member
Author
|
I think this one should probably be a draft. I'm not certain this is the right choice for async-h1, but can throw together a PR branch for async-h1 that uses this branch and see what the consequences are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #297
do not merge until 3.0