feat(http-server):Add a configuration file to store frequently used configuration values #770#769
Open
wayfarer3130 wants to merge 3 commits intohttp-party:masterfrom
Open
Conversation
wayfarer3130
changed the title
|
This pull request has been inactive for 360 days |
Contributor
|
There are probably security concerns to automatically executing javascript files in the same directory, especially if this is enabled by default... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple change to be able to configure http-server via a javascript file. This change in particular allows replacing the before methods to perform more complex configuration tasks. It is theoretically possible to do that in nconf, but it doesn't support JavaScript out of the box, and some sort of more complex configuration is required to do things like renaming the path on the fly, or writing a non-GET handler, dynamically computing time to cache etc.