Fixes #670: Added support for printing out the Common Name from the SSL certificate that is being used.#675
Open
bramp wants to merge 4 commits intohttp-party:masterfrom
Open
Fixes #670: Added support for printing out the Common Name from the SSL certificate that is being used.#675bramp wants to merge 4 commits intohttp-party:masterfrom
bramp wants to merge 4 commits intohttp-party:masterfrom
Conversation
…ad, and reduced code duplication.
…or tests related changes: * Every httpServer.createServer now has a vow to check for errors. Additionally, the server object is returned, instead of using the callbacks. This is because the server is an EventEmitter, and vows.js can capture the error correctly. * Documented respondsWithMessage function * Refactored one case of checking for a 404 with respondsWith(404, ...)
…from the SSL certificate that is being used. This avoids SSL errors when going to the host (such as a IP address) that doesn't match the name in the certificate.
Member
|
I think this looks really good! And I'm impressed by the small addition to grab something like that! Unfortunately, there have been some major changes in master, especially to the tests, and there are some pretty big conflicts to solve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
New Feature
Fixes #670: Added support for printing out the Common Name from the SSL certificate that is being used.
This avoids SSL errors when going to the host (such as a IP address) that doesn't match the name in the certificate.
What changes did you make?
Provide some example code that this change will affect, if applicable:
N/A
Is there anything you'd like reviewers to focus on?
Please provide testing instructions, if applicable: