fix: pass arguments to server.close#635
Open
KoltesDigital wants to merge 1 commit intohttp-party:masterfrom
Open
fix: pass arguments to server.close#635KoltesDigital wants to merge 1 commit intohttp-party:masterfrom
KoltesDigital wants to merge 1 commit intohttp-party:masterfrom
Conversation
thornjad
requested changes
Aug 16, 2021
Member
thornjad
left a comment
There was a problem hiding this comment.
I like this!
All that's left to do:
- merge
masterand let the new tests run (we've changed a lot since this PR was opened) - add at least one test to ensure arguments are passed properly. This is less about testing your changes, more about ensuring future changes don't break this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Rather bug fix.
What changes did you make?
As for
server.listen,server.close(both for HTTP and HTTPS servers, as returned by union) takes an optional callback which is called on completion or error. This patch adds argument forwarding forclose.Provide some example code that this change will affect, if applicable:
Is there anything you'd like reviewers to focus on?
Well there's no tests, should I somehow write one?
As a side note,
HttpServer.prototype.closeforwards the return value ofthis.server.close, i.e.this. ButHttpServer.prototype.listendoes not. I think it should too.Please provide testing instructions, if applicable:
Above code.