First pass at documenting html5lib.filters#375
Merged
gsnedders merged 1 commit intohtml5lib:masterfrom Dec 3, 2017
willkg:307-filters
Merged
First pass at documenting html5lib.filters#375gsnedders merged 1 commit intohtml5lib:masterfrom willkg:307-filters
gsnedders merged 1 commit intohtml5lib:masterfrom
willkg:307-filters
Conversation
Contributor
Author
|
@gsnedders, @jgraham Can one of you review this, please? |
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 50 50
Lines 6950 6950
Branches 1328 1328
=======================================
Hits 6308 6308
Misses 483 483
Partials 159 159
Continue to review full report at Codecov.
|
hugovk
approved these changes
Nov 30, 2017
gsnedders
reviewed
Nov 30, 2017
html5lib/filters/whitespace.py
Outdated
|
|
||
| class Filter(base.Filter): | ||
|
|
||
| """Collapses whitespace except in pre and textarea tags""" |
Member
There was a problem hiding this comment.
Elements, not tags. Also it's more than just pre and textarea; I think script is in rcdataElements too.
Contributor
Author
|
^^^ @gsnedders Does that fix the issue? I sort of understand it, but I'm not sure I know enough to know if it's completely fixed or not. |
Contributor
Author
|
@gsnedders Can you review this please? |
gsnedders
approved these changes
Dec 3, 2017
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers
html5lib.filtersin issue #307.Is this documentation for filters clear enough for a 1.0?