Skip to content

Added seamless boolean attribute for iframe #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willkg merged 6 commits into from
Nov 1, 2017
Merged

Added seamless boolean attribute for iframe #176

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1be9532
Added iframe seamless boolean attribute
RitwikGupta Nov 24, 2014
4dfe3cd
Update CHANGES.rst
RitwikGupta Nov 24, 2014
7fd79e3
Update AUTHORS.rst
RitwikGupta Nov 24, 2014
01011c2
Merge branch 'master' into master
RitwikGupta Oct 4, 2017
b47e3a1
Remove tuple regression, use lists
RitwikGupta Oct 5, 2017
27122c6
Merge branch 'master' into master
RitwikGupta Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Patches and suggestions
- Andreas Madsack
- Karim Valiev
- Marc DM
- Ritwik Gupta
- Tony Lopes
- lilbludevil
- Simon Sapin
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Change Log
----------

* Added the seamless attribute for iframes.

0.999999999/1.0b10
~~~~~~~~~~~~~~~~~~

Expand Down
37 changes: 19 additions & 18 deletions html5lib/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,24 +588,25 @@
])

booleanAttributes = {
"": frozenset(["irrelevant"]),
"style": frozenset(["scoped"]),
"img": frozenset(["ismap"]),
"audio": frozenset(["autoplay", "controls"]),
"video": frozenset(["autoplay", "controls"]),
"script": frozenset(["defer", "async"]),
"details": frozenset(["open"]),
"datagrid": frozenset(["multiple", "disabled"]),
"command": frozenset(["hidden", "disabled", "checked", "default"]),
"hr": frozenset(["noshade"]),
"menu": frozenset(["autosubmit"]),
"fieldset": frozenset(["disabled", "readonly"]),
"option": frozenset(["disabled", "readonly", "selected"]),
"optgroup": frozenset(["disabled", "readonly"]),
"button": frozenset(["disabled", "autofocus"]),
"input": frozenset(["disabled", "readonly", "required", "autofocus", "checked", "ismap"]),
"select": frozenset(["disabled", "readonly", "autofocus", "multiple"]),
"output": frozenset(["disabled", "readonly"]),
"": frozenset(("irrelevant",)),
"style": frozenset(("scoped",)),
"img": frozenset(("ismap",)),
"audio": frozenset(("autoplay", "controls")),
"video": frozenset(("autoplay", "controls")),
"script": frozenset(("defer", "async")),
"details": frozenset(("open",)),
"datagrid": frozenset(("multiple", "disabled")),
"command": frozenset(("hidden", "disabled", "checked", "default")),
"hr": frozenset(("noshade")),
Copy link
Contributor

@willkg willkg Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is also missing a comma.

Copy link
Member

@gsnedders gsnedders Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression, and why we moved to lists. Presumably just copy/paste from the old branch?

Copy link
Contributor Author

@RitwikGupta RitwikGupta Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my fault, I chose the wrong revision when fixing the merge conflicts. Will fix!

"menu": frozenset(("autosubmit",)),
"fieldset": frozenset(("disabled", "readonly")),
"option": frozenset(("disabled", "readonly", "selected")),
"optgroup": frozenset(("disabled", "readonly")),
"button": frozenset(("disabled", "autofocus")),
"input": frozenset(("disabled", "readonly", "required", "autofocus", "checked", "ismap")),
"select": frozenset(("disabled", "readonly", "autofocus", "multiple")),
"output": frozenset(("disabled", "readonly")),
"iframe": frozenset(("seamless")),
Copy link
Contributor

@willkg willkg Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

First, you changed all the lists to tuples. I'm not sure why you did that. One problem tuples has is that in order to make something a one-item tuple, you need a comma. Forgetting it causes problems ...

Which brings me to the second thing--this one is missing that comma. So this is creating a frozenset of ['s', 'e', 'a', 'm', 'l', 'e', 's', 's'] which is not what we want.

Can you fix this? I'd also prefer it if you switched these back to lists.

Copy link
Member

@gsnedders gsnedders Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We switched them all over to lists ages ago to avoid the missing-comma issue.

}

# entitiesWindows1252 has to be _ordered_ and needs to have an index. It
Expand Down