A first attempt at fixing #100 (method dispatcher duplicates)#108
Closed
gsnedders wants to merge 1 commit intohtml5lib:masterfrom
Closed
A first attempt at fixing #100 (method dispatcher duplicates)#108gsnedders wants to merge 1 commit intohtml5lib:masterfrom
gsnedders wants to merge 1 commit intohtml5lib:masterfrom
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/254 This is an external review system which you may optionally use for the code review of your pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrary to the comment, I haven't looked at performance impact. I expect almost none (that stuff is run once per parser instance, no?). Also don't know why a PR wasn't sent a while ago for this. See also #106. Fixes #100.