Ci Update runners and fix tests #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarzec
commented
Jan 7, 2026
| compiler: cl.exe | ||
| cxx_std: c++20 | ||
| stdlib: default | ||
| # Comment out Windows tests until build on Windows is fixed |
Contributor
Author
There was a problem hiding this comment.
@hsutter I did this to allow the tests to turn all green without the failure caused by build failures on Windows runners.
This will allow to quickly see if a PR adds regression or not without going into details of the failure each time and see if it only the Windows runner that fails.
I will try to have a look at those failures and fix the root cause. When it is fixed I will reenable Windows runners.
The same applies to the regression test workflow.
jarzec
commented
Jan 7, 2026
jarzec
force-pushed
the
ci-update-runners-fix-tests
branch
from
0d1fda1 to
855d012
Compare
Owner
|
Thanks again for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
.github/workflows/:regression-tests.yml→regression-tests.yamlfor consistency,Adjust
regression-tests/run-tests.shaccordingly.In addition the
-include-stdcppfront option was added forpure2-*tests. This is necessary after the updates of test files from #1405 (thanks @gregmarr).