chore: regenerate client from updated OpenAPI spec by hotdata-automation[bot] · Pull Request #7 · hotdata-dev/sdk-typescript

hotdata-automation · 2026-03-12T22:05:44Z

Auto-generated from updated HotData OpenAPI spec.

github-actions · 2026-03-14T03:46:26Z

Automated review unavailable (Claude step failed). Please review manually.

claude · 2026-03-14T04:05:48Z

.gitignore

+wwwroot/*.js
+node_modules
+typings
+dist


P0 – .env no longer ignored

The generator replaced the existing .gitignore and dropped the .env entry. If any developer has a local .env file with API tokens or credentials, it can now be accidentally committed.

Suggested change

dist

wwwroot/*.js

node_modules

typings

dist

.env

*.tsbuildinfo

claude · 2026-03-14T04:05:50Z

package.json

+  "author": "OpenAPI-Generator",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"


P1 – Unfilled generator placeholder

GIT_USER_ID/GIT_REPO_ID is a template token that OpenAPI Generator leaves in output. It needs to be replaced with the actual repository path before this merges, otherwise npm info @hotdata/sdk will show a broken repository URL.

Suggested change

"url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"

"url": "https://github.com/hotdata-dev/sdk-typescript.git"

claude · 2026-03-14T04:05:51Z

tsconfig.json

-    "target": "ES2022",
-    "module": "Node16",
-    "moduleResolution": "Node16",
    "declaration": true,


P1 – strict: true removed

The old tsconfig had "strict": true. The generator's default tsconfig omits it entirely, which silently disables all strict checks (strictNullChecks, noImplicitAny, etc.). This weakens type safety across the whole SDK. Consider adding it back to compilerOptions.

Suggested change

"declaration": true,

"declaration": true,

"strict": true,

"target": "es6",

claude · 2026-03-14T04:05:52Z

package.json

-    "prepublishOnly": "npm run build"
+    "build": "tsc && tsc -p tsconfig.esm.json",
+    "prepare": "npm run build"
  },


P2 – license field removed

The previous package.json declared "license": "MIT". The generator dropped it, which means npm will warn on publish and the package will show "none" on npmjs.com. Consider adding it back.

claude · 2026-03-14T04:05:53Z

README.md

+
+  const body = {
+    // string | Connection ID
+    connectionId: connectionId_example,


P2 – Broken example code

connectionId_example is referenced but never declared. Copy-pasting this snippet produces a ReferenceError at runtime and a compile error with strict mode. All similar examples throughout the docs/ files have the same issue. Replace with an inline string literal, e.g. "my-connection-id".

claude

Review

Issues

P0 – .gitignore drops .env (.gitignore line 4): The generator replaced the existing .gitignore with its own template, silently removing the .env entry. Any developer with a local .env file containing API tokens can now accidentally commit credentials.
P1 – Unfilled generator placeholder (package.json line 8): "url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git" is an OpenAPI Generator template token. It was not replaced before the PR was raised.
P1 – strict: true removed (tsconfig.json): The generator's default tsconfig omits strict mode entirely. This disables strictNullChecks, noImplicitAny, and related checks across the entire SDK, which undermines type safety.

Action Required

Restore .env (and *.tsbuildinfo) in .gitignore.
Replace GIT_USER_ID/GIT_REPO_ID with hotdata-dev/sdk-typescript in package.json.
Add "strict": true back to tsconfig.json compilerOptions.

The automation that runs the generator should either post-process these known artifacts or maintain a set of patches that are re-applied after each regeneration.

claude · 2026-03-16T17:51:31Z

package.json

+  "author": "OpenAPI-Generator",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"


P1 — Unfilled template placeholder. This will be published to npm with an invalid repository URL. Replace with the actual repo:

Suggested change

"url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"

"url": "https://github.com/hotdata-dev/sdk-typescript.git"

claude · 2026-03-16T17:51:35Z

package.json

-  "types": "dist/index.d.ts",
+  "version": "1.0.0",
+  "description": "OpenAPI client for @hotdata/sdk",
+  "author": "OpenAPI-Generator",


P2 — Generator boilerplate. author should identify the actual maintainer, not the tool that generated the code.

Suggested change

"author": "OpenAPI-Generator",

"author": "HotData",

claude · 2026-03-16T17:51:40Z

tsconfig.json

-    "target": "ES2022",
-    "module": "Node16",
-    "moduleResolution": "Node16",
    "declaration": true,


P1 — strict: true was dropped. The generator's default tsconfig disables strict mode, but the previous config had it enabled. Without it, noImplicitAny, strictNullChecks, and other safety checks are off — allowing the generated any types to silently widen. Add it back:

Suggested change

"declaration": true,

"declaration": true,

"strict": true,

claude

Review

Issues

package.json:8 — Repository URL is an unfilled OpenAPI Generator template placeholder (GIT_USER_ID/GIT_REPO_ID). This will be published to npm with an invalid repository link.
tsconfig.json:3 — strict: true was dropped by the generator's default config. The previous tsconfig had it enabled; removing it silently disables noImplicitAny, strictNullChecks, and related checks across the entire SDK.

Action Required

Fix package.json repository.url to https://github.com/hotdata-dev/sdk-typescript.git.
Re-add "strict": true to tsconfig.json compilerOptions. If generated code does not compile under strict mode, configure the generator to produce stricter output or post-process — do not lower the bar for the whole SDK.

claude · 2026-03-17T03:47:48Z

.gitignore

+wwwroot/*.js
+node_modules
+typings
+dist


The generator-provided .gitignore dropped .env, which was present in the original. Without this entry, environment files containing API tokens and secrets could be accidentally committed.

Suggested change

dist

wwwroot/*.js

node_modules

typings

dist

.env

claude · 2026-03-17T03:47:50Z

package.json

+  "author": "OpenAPI-Generator",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"


Unresolved OpenAPI Generator template placeholder. This needs to point to the actual repository before publishing.

Suggested change

"url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"

"url": "https://github.com/hotdata-dev/sdk-typescript.git"

claude · 2026-03-17T03:47:53Z

tsconfig.json

-    "module": "Node16",
-    "moduleResolution": "Node16",
    "declaration": true,
+    "target": "es6",


The generator downgraded the compile target from ES2022 to es6 and dropped strict: true. Losing strict mode silently disables null checks, implicit any, strict function types, etc. — type errors that previously would have been caught at compile time can now slip through.

The original config should be preserved for these settings:

Suggested change

"target": "es6",

"target": "ES2022",

claude · 2026-03-17T03:47:56Z

tsconfig.json

  },
-  "include": ["src"]
+  "exclude": [
+    "dist",
+    "node_modules"
+  ]
 }


strict: true, esModuleInterop: true, and rootDir: "src" were all dropped. strict is the critical one (see comment above). rootDir should also be restored — without it the compiler may pick up files outside src/ and produce a different output tree.

Suggested change

},

"include": ["src"]

"exclude": [

"dist",

"node_modules"

]

}

},

"include": ["src"]

}

claude

Review

Issues

P0 — .gitignore drops .env
The generator-provided .gitignore removes the .env entry that was in the original. Environment files containing API tokens and other secrets can now be accidentally committed. Must be restored before merge.

P1 — package.json: unresolved template placeholder in repository.url
"url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git" is a raw OpenAPI Generator placeholder. Any tooling (npm, GitHub, pkg managers) that reads this field will get bad data.

P1 — tsconfig.json: strict: true dropped, target downgraded
The generator replaced the project's tsconfig.json with its own defaults, removing strict: true, esModuleInterop: true, rootDir: "src", and downgrading the compile target from ES2022 to es6. Dropping strict is the critical regression — it disables null checks, implicit any detection, and strict function types, meaning type errors that the original config would have caught will now pass silently.

Action Required

Add .env back to .gitignore
Replace GIT_USER_ID/GIT_REPO_ID in package.json with hotdata-dev/sdk-typescript
Restore strict: true, target: "ES2022", rootDir: "src", and esModuleInterop: true in tsconfig.json — or configure the OpenAPI generator to preserve these settings so they survive future regenerations

claude · 2026-03-17T19:31:38Z

package.json

+  "author": "OpenAPI-Generator",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"


Unresolved generator placeholder — this will ship to npm with a broken repository URL. Replace with the actual repo URL:

Suggested change

"url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"

"url": "https://github.com/hotdata-dev/sdk-typescript.git"

claude · 2026-03-17T19:31:39Z

tsconfig.json

+    "moduleResolution": "node",
    "outDir": "dist",
-    "rootDir": "src",
-    "strict": true,


strict: true was dropped by the generator. This disables a whole class of TypeScript safety checks (strictNullChecks, noImplicitAny, etc.) across the entire codebase. Add it back to the generated tsconfig.json:

Suggested change

"strict": true,

"strict": true,

claude

Review

Issues

package.json line 8 — Generator placeholder GIT_USER_ID/GIT_REPO_ID left in the repository URL. This will be published to npm with a broken/misleading repo link.
tsconfig.json — strict: true was removed by the generator. This silently disables strictNullChecks, noImplicitAny, and other checks across the entire SDK. The generated code almost certainly has latent type errors that strict mode would surface.

Action Required

Fix the repository URL in package.json to point to https://github.com/hotdata-dev/sdk-typescript.git
Add "strict": true back to tsconfig.json compilerOptions, and resolve any resulting type errors in the generated code
Consider adding these as overrides in .openapi-generator-ignore or a post-generation patch script so future regenerations do not regress them

hotdata-automation bot force-pushed the openapi-update branch 3 times, most recently from c6dbf0d to 9adce2b Compare March 14, 2026 03:46

zfarrell closed this Mar 14, 2026

zfarrell reopened this Mar 14, 2026

claude bot reviewed Mar 14, 2026

View reviewed changes

claude bot requested changes Mar 14, 2026

View reviewed changes

hotdata-automation bot force-pushed the openapi-update branch from 9adce2b to 97e1681 Compare March 16, 2026 17:49

claude bot reviewed Mar 16, 2026

View reviewed changes

claude bot requested changes Mar 16, 2026

View reviewed changes

hotdata-automation bot force-pushed the openapi-update branch from 97e1681 to 42936a4 Compare March 17, 2026 03:45

claude bot reviewed Mar 17, 2026

View reviewed changes

claude bot requested changes Mar 17, 2026

View reviewed changes

chore: regenerate client from OpenAPI spec

a19aff2

hotdata-automation bot force-pushed the openapi-update branch from 42936a4 to a19aff2 Compare March 17, 2026 19:29

claude bot reviewed Mar 17, 2026

View reviewed changes

claude bot requested changes Mar 17, 2026

View reviewed changes

	"url": "https://github.com/GIT_USER_ID/GIT_REPO_ID.git"
	"url": "https://github.com/hotdata-dev/sdk-typescript.git"

Conversation

hotdata-automation bot commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

claude bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Review

Issues

Action Required

Uh oh!

claude bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Review

Issues

Action Required

Uh oh!

claude bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Review

Issues

Action Required

Uh oh!

claude bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Review

Issues

Action Required

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant