chore: regenerate client from updated OpenAPI spec#16
Conversation
|
Automated review unavailable (Claude step failed). Please review manually. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| [features] | ||
| default = ["native-tls"] | ||
| native-tls = ["reqwest/native-tls"] | ||
| rustls = ["reqwest/rustls"] |
There was a problem hiding this comment.
The reqwest feature flag is wrong. In reqwest 0.13, the rustls feature is named rustls-tls, not rustls. Since default-features = false is set on the reqwest dependency, anyone who enables this crate's rustls feature will silently get no TLS backend at all, causing all HTTPS connections to fail at runtime.
| rustls = ["reqwest/rustls"] | |
| rustls = ["reqwest/rustls-tls"] |
There was a problem hiding this comment.
Review
Issues
Cargo.toml, line 20 — rustls = ["reqwest/rustls"] references a non-existent reqwest feature. reqwest 0.13's rustls feature is named rustls-tls. Because reqwest is declared with default-features = false, enabling this crate's rustls feature activates no TLS backend, causing all HTTPS connections to fail silently at runtime.
Action Required
Change line 20 in Cargo.toml to:
rustls = ["reqwest/rustls-tls"]
zfarrell
dismissed
claude[bot]’s stale review
this is coming from the open api generator template
1 participant
Auto-generated from updated HotData OpenAPI spec.