chore: regenerate client from updated OpenAPI spec#14
chore: regenerate client from updated OpenAPI spec#14hotdata-automation[bot] wants to merge 2 commits intomainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| authors = ["OpenAPI Generator team and contributors"] | ||
| description = "Powerful data platform API for datasets, queries, and analytics." | ||
| # Override this license by providing a License Object in the OpenAPI. | ||
| license = "Unlicense" |
There was a problem hiding this comment.
P1 — Unintentional license change. The generator template defaults to Unlicense and even leaves a breadcrumb comment saying to override it. The original project license was MIT. Shipping this would silently change the legal terms of the published crate.
| license = "Unlicense" | |
| license = "MIT" |
| description = "Rust client for the HotData API" | ||
| license = "MIT" | ||
| version = "1.0.0" | ||
| authors = ["OpenAPI Generator team and contributors"] |
There was a problem hiding this comment.
Generator default — should be removed or replaced with the actual project author(s). Publishing with "OpenAPI Generator team and contributors" is misleading.
| authors = ["OpenAPI Generator team and contributors"] | |
| authors = ["HotData"] |
| impl Default for Configuration { | ||
| fn default() -> Self { | ||
| Configuration { | ||
| base_path: "https://app.hotdata.dev".to_owned(), |
There was a problem hiding this comment.
The hardcoded version 0.0.0 doesn't match the package version (1.0.0). Consider deriving this from env!("CARGO_PKG_VERSION") so it stays in sync automatically.
| base_path: "https://app.hotdata.dev".to_owned(), | |
| user_agent: Some(format!("hotdata-rust/{}", env!("CARGO_PKG_VERSION"))), |
| return params; | ||
| } | ||
|
|
||
| unimplemented!("Only objects are supported with style=deepObject") |
There was a problem hiding this comment.
unimplemented!() panics at runtime. Since this function is public, a caller passing a non-object serde_json::Value (e.g. an array or scalar) will crash the process. Consider returning a Vec (empty or with a best-effort conversion) or making the function return Result/Option instead.
There was a problem hiding this comment.
Review
Issues
Cargo.tomlline 7 — License changed fromMITtoUnlicense. The generator template emitsUnlicenseas its default and even comments that it should be overridden. This silently changes the published crate's legal terms. Must be restored toMITbefore merge.
Action Required
Restore license = "MIT" in Cargo.toml. The generator's Unlicense default should be suppressed via the generator config (e.g. .openapi-generator-ignore or a custom template override for Cargo.toml.mustache) so future regenerations don't reintroduce this.
1 participant
Auto-generated from updated HotData OpenAPI spec.