feat(datasets): Add datasets commands to create, list, and view datasets in CLI#3
Merged
feat(datasets): Add datasets commands to create, list, and view datasets in CLI#3
Conversation
…etails for datasets
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
| @@ -27,6 +27,8 @@ rand = "0.8" | |||
| sha2 = "0.10" | |||
| tiny_http = "0.12" | |||
| comfy-table = "7" | |||
Contributor
There was a problem hiding this comment.
The nix crate is only used inside a #[cfg(target_os = "macos")] block (stdin_redirect_filename), but it's declared as an unconditional dependency. This means it compiles and links on Linux and Windows even though it's never called there.
Consider a platform-scoped dependency:
Suggested change
| comfy-table = "7" | |
| nix = { version = "0.29", features = ["fs"], optional = true } |
and activate it only for macOS in [target.'cfg(target_os = "macos")'.dependencies], or use a target-specific dependency table directly:
[target.'cfg(target_os = "macos")'.dependencies]
nix = { version = "0.29", features = ["fs"] }
Contributor
There was a problem hiding this comment.
Review
Issues
- src/datasets.rs line 399–402 —
body.countis used both to display the page size and to compute the next--offset. Ifcountis the total number of records (the common REST API convention), the suggested--offsetwill be wrong — pointing past all data rather than to the next page. Usebody.datasets.len()instead, which is always correct.
Action Required
Clarify or fix the count field semantics in ListResponse. If it is page-scoped, add a comment stating that. If it is total-scoped (or unknown), switch to body.datasets.len() for both the display and the offset hint before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.