Skip to content

feat(datasets): Add datasets commands to create, list, and view datasets in CLI#3

Merged
pthurlow merged 8 commits intomainfrom
feat/upload-api
Mar 13, 2026
Merged

feat(datasets): Add datasets commands to create, list, and view datasets in CLI#3
pthurlow merged 8 commits intomainfrom
feat/upload-api

Conversation

@pthurlow
Copy link
Collaborator

No description provided.

claude[bot]

This comment was marked as outdated.

pthurlow and others added 2 commits March 13, 2026 14:34
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

claude[bot]

This comment was marked as outdated.

@@ -27,6 +27,8 @@ rand = "0.8"
sha2 = "0.10"
tiny_http = "0.12"
comfy-table = "7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nix crate is only used inside a #[cfg(target_os = "macos")] block (stdin_redirect_filename), but it's declared as an unconditional dependency. This means it compiles and links on Linux and Windows even though it's never called there.

Consider a platform-scoped dependency:

Suggested change
comfy-table = "7"
nix = { version = "0.29", features = ["fs"], optional = true }

and activate it only for macOS in [target.'cfg(target_os = "macos")'.dependencies], or use a target-specific dependency table directly:

[target.'cfg(target_os = "macos")'.dependencies]
nix = { version = "0.29", features = ["fs"] }

claude[bot]
claude bot previously requested changes Mar 13, 2026
Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

  • src/datasets.rs line 399–402body.count is used both to display the page size and to compute the next --offset. If count is the total number of records (the common REST API convention), the suggested --offset will be wrong — pointing past all data rather than to the next page. Use body.datasets.len() instead, which is always correct.

Action Required

Clarify or fix the count field semantics in ListResponse. If it is page-scoped, add a comment stating that. If it is total-scoped (or unknown), switch to body.datasets.len() for both the display and the offset hint before merging.

@pthurlow pthurlow dismissed claude[bot]’s stale review March 13, 2026 22:12

review reason is invalid

@pthurlow pthurlow merged commit d5ac1e1 into main Mar 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant