Skip to content

feat(jobs): Add jobs commands#15

Merged
pthurlow merged 2 commits intomainfrom
feat/jobs
Mar 24, 2026
Merged

feat(jobs): Add jobs commands#15
pthurlow merged 2 commits intomainfrom
feat/jobs

Conversation

@pthurlow
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

  • src/jobs.rs:175-179 — Pagination is broken for the default active-job view. Two separate API calls are made with the same limit and offset applied independently: --limit 10 can return up to 20 results, and --offset N skips N from each set separately, making pagination over the combined result meaningless.

Action Required

Fix the default active-job fetch so that --limit/--offset behave correctly over the combined pending+running set. Options: fetch both without pagination and slice client-side, support a multi-status query param on the API, or document and enforce that --limit/--offset are incompatible with the default view.

claude[bot]
claude bot previously requested changes Mar 24, 2026
Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

  • src/jobs.rs lines 175–179--limit and --offset are broken in the default active-jobs view. Two separate API calls are made (one for pending, one for running) each receiving the same limit and offset values. This means --limit 10 can return up to 20 results, and --offset 5 skips 5 records from each status bucket independently rather than from the combined set. See inline comment for fix options.

Action Required

Decide how to handle pagination in the default active view (two-call merge) and implement one of the options described in the inline comment before merging.

@pthurlow pthurlow dismissed claude[bot]’s stale review March 24, 2026 21:42

Non necessary fix at the moment

@pthurlow pthurlow merged commit c1a86b3 into main Mar 24, 2026
7 checks passed
@pthurlow pthurlow deleted the feat/jobs branch March 24, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant