Conversation
Contributor
There was a problem hiding this comment.
Review
Issues
src/jobs.rs:175-179— Pagination is broken for the default active-job view. Two separate API calls are made with the samelimitandoffsetapplied independently:--limit 10can return up to 20 results, and--offset Nskips N from each set separately, making pagination over the combined result meaningless.
Action Required
Fix the default active-job fetch so that --limit/--offset behave correctly over the combined pending+running set. Options: fetch both without pagination and slice client-side, support a multi-status query param on the API, or document and enforce that --limit/--offset are incompatible with the default view.
Contributor
There was a problem hiding this comment.
Review
Issues
src/jobs.rslines 175–179 —--limitand--offsetare broken in the default active-jobs view. Two separate API calls are made (one forpending, one forrunning) each receiving the samelimitandoffsetvalues. This means--limit 10can return up to 20 results, and--offset 5skips 5 records from each status bucket independently rather than from the combined set. See inline comment for fix options.
Action Required
Decide how to handle pagination in the default active view (two-call merge) and implement one of the options described in the inline comment before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.